javascript - Twitter Jquery Widget: Creating invalid URLS -


i have twitter widget on website. problem is, creating invalid urls link when click on "about 5 hours ago.."

example: if click on recent tweet takes link, invalid: http://twitter.com/#!/ohshititsjake/statuses/63741419709411330

the correct url is: http://twitter.com/#!/ohshititsjake/statuses/63741419709411328

here part of script believe problem:

 ` function build_url() {       var proto = ('https:' == document.location.protocol ? 'https:' : 'http:');       if (s.list) {         return proto+"//api.twitter.com/1/"+s.username[0]+"/lists/"+s.list+"/statuses.json?per_page="+s.count+"&callback=? ";       } else if (s.query == null && s.username.length == 1) {         return proto+'//api.twitter.com/1/statuses/user_timeline.json?screen_name='+s.username[0]+'&count='+s.count+'&callback=?';       } else {         var query = (s.query || 'from:'+s.username.join(' or from:'));         return proto+'//search.twitter.com/search.json?&q='+escape(query)+'&rpp='+s.count+'&callback=?';       }     } ` 

here full javascript:

(function($) {    $.fn.tweet = function(o){     var s = {       username: ["ohshititsjake"],                   list: null,                                     avatar_size: 20,                             count: 3,                                      intro_text: null,                              outro_text: null,                              join_text:  null,                              auto_join_text_default: "i said:<br/>",             auto_join_text_ed: "i",                        auto_join_text_ing: "i said:<br/>",                    auto_join_text_reply: "i replied to",          auto_join_text_url: "i looking at",        loading_text: null,                            query: null                                  };      if(o) $.extend(s, o);      $.fn.extend({       linkurl: function() {         var returning = [];         var regexp = /((ftp|http|https):\/\/(\w+:{0,1}\w*@)?(\s+)(:[0-9]+)?(\/|\/([\w#!:.?+=&%@!\-\/]))?)/gi;         this.each(function() {           returning.push(this.replace(regexp,"<a href=\"$1\">$1</a>"));         });         return $(returning);       },       linkuser: function() {         var returning = [];         var regexp = /[\@]+([a-za-z0-9-_]+)/gi;         this.each(function() {           returning.push(this.replace(regexp,"<a href=\"http://twitter.com/$1\">@$1</a>"));         });         return $(returning);       },       linkhash: function() {         var returning = [];         var regexp = /(?:^| )[\#]+([a-za-z0-9-_]+)/gi;         this.each(function() {           returning.push(this.replace(regexp, ' <a href="http://search.twitter.com/search?q=&tag=$1&lang=all&from='+s.username.join("%2bor%2b")+'">#$1</a>'));         });         return $(returning);       },       capawesome: function() {         var returning = [];         this.each(function() {           returning.push(this.replace(/\b(awesome)\b/gi, '<span class="awesome">$1</span>'));         });         return $(returning);       },       capepic: function() {         var returning = [];         this.each(function() {           returning.push(this.replace(/\b(epic)\b/gi, '<span class="epic">$1</span>'));         });         return $(returning);       },       makeheart: function() {         var returning = [];         this.each(function() {           returning.push(this.replace(/(&lt;)+[3]/gi, "<tt class='heart'>&#x2665;</tt>"));         });         return $(returning);       }     });      function parse_date(date_str) {       // non-search twitter apis return inconsistently-formatted dates, date.parse       // cannot handle in ie. therefore perform following transformation:       // "wed apr 29 08:53:31 +0000 2009" => "wed, apr 29 2009 08:53:31 +0000"       return date.parse(date_str.replace(/^([a-z]{3})( [a-z]{3} \d\d?)(.*)( \d{4})$/i, '$1,$2$4$3'));     }      function relative_time(time_value) {       var parsed_date = parse_date(time_value);       var relative_to = (arguments.length > 1) ? arguments[1] : new date();       var delta = parseint((relative_to.gettime() - parsed_date) / 1000);       var pluralize = function (singular, n) {         return '' + n + ' ' + singular + (n == 1 ? '' : 's');       };       if(delta < 60) {       return 'less minute ago';       } else if(delta < (60*60)) {       return 'about ' + pluralize("minute", parseint(delta / 60)) + ' ago';       } else if(delta < (24*60*60)) {       return 'about ' + pluralize("hour", parseint(delta / 3600)) + ' ago';       } else {       return 'about ' + pluralize("day", parseint(delta / 86400)) + ' ago';       }     }      function build_url() {       var proto = ('https:' == document.location.protocol ? 'https:' : 'http:');       if (s.list) {         return proto+"//api.twitter.com/1/"+s.username[0]+"/lists/"+s.list+"/statuses.json?per_page="+s.count+"&callback=? ";       } else if (s.query == null && s.username.length == 1) {         return proto+'//api.twitter.com/1/statuses/user_timeline.json?screen_name='+s.username[0]+'&count='+s.count+'&callback=?';       } else {         var query = (s.query || 'from:'+s.username.join(' or from:'));         return proto+'//search.twitter.com/search.json?&q='+escape(query)+'&rpp='+s.count+'&callback=?';       }     }      return this.each(function(i, widget){       var list = $('<ul class="tweet_list">').appendto(widget);       var intro = '<p class="tweet_intro">'+s.intro_text+'</p>';       var outro = '<p class="tweet_outro">'+s.outro_text+'</p>';       var loading = $('<p class="loading">'+s.loading_text+'</p>');        if(typeof(s.username) == "string"){         s.username = [s.username];       }        if (s.loading_text) $(widget).append(loading);       $.getjson(build_url(), function(data){         if (s.loading_text) loading.remove();         if (s.intro_text) list.before(intro);         var tweets = (data.results || data);         $.each(tweets, function(i,item){           // auto join text based on verb tense , content           if (s.join_text == "auto") {             if (item.text.match(/^(@([a-za-z0-9-_]+)) .*/i)) {               var join_text = s.auto_join_text_reply;             } else if (item.text.match(/(^\w+:\/\/[a-za-z0-9-_]+\.[a-za-z0-9-_:%&\?\/.=]+) .*/i)) {               var join_text = s.auto_join_text_url;             } else if (item.text.match(/^((\w+ed)|just) .*/im)) {               var join_text = s.auto_join_text_ed;             } else if (item.text.match(/^(\w*ing) .*/i)) {               var join_text = s.auto_join_text_ing;             } else {               var join_text = s.auto_join_text_default;             }           } else {             var join_text = s.join_text;           };            var from_user = item.from_user || item.user.screen_name;           var profile_image_url = item.profile_image_url || item.user.profile_image_url;           var join_template = '<span class="tweet_join"> '+join_text+' </span>';           var join = ((s.join_text) ? join_template : ' ');           var avatar_template = '<a class="tweet_avatar" href="http://twitter.com/'+from_user+'"><img src="'+profile_image_url+'" height="'+s.avatar_size+'" width="'+s.avatar_size+'" alt="'+from_user+'\'s avatar" title="'+from_user+'\'s avatar" border="0"/></a>';           var avatar = (s.avatar_size ? avatar_template : '');           var date = '<span class="tweet_time"><a href="http://twitter.com/'+from_user+'/statuses/'+item.id+'" title="view tweet on twitter">'+relative_time(item.created_at)+'</a></span>';           var text = '<span class="tweet_text">' +$([item.text]).linkurl().linkuser().linkhash().makeheart().capawesome().capepic()[0]+ '</span>';            // until create template option, arrange items below alter tweet's display.           list.append('<li>' + avatar + date + join + text + '</li>');            list.children('li:first').addclass('tweet_first');           list.children('li:odd').addclass('tweet_even');           list.children('li:even').addclass('tweet_odd');         });         if (s.outro_text) list.after(outro);         $(widget).trigger("loaded").trigger((tweets.length == 0 ? "empty" : "full"));       });      });   }; })(jquery); 

looking @ permalink's ids on user account, don't match ids getting generated in post. answer in post:

why wrong tweet id returned twitter api?

so try changing line:

var date = '<span class="tweet_time"><a href="http://twitter.com/'+from_user+'/statuses/'+item.id+'" title="view tweet on twitter">'+relative_time(item.created_at)+'</a></span>'; 

to this:

var date = '<span class="tweet_time"><a href="http://twitter.com/'+from_user+'/statuses/'+item.id_str+'" title="view tweet on twitter">'+relative_time(item.created_at)+'</a></span>'; 

really, it's changing item.id item.id_str.in middle of line.


Comments